Skip to content

WWSTCERT-8471/8468 [Aqara] Wireless Remote Switch T1(Single/Double) #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 30, 2025
Merged

WWSTCERT-8471/8468 [Aqara] Wireless Remote Switch T1(Single/Double) #2458

merged 5 commits into from
Oct 30, 2025

Conversation

@seojune79
Copy link
Contributor

@seojune79 seojune79 commented Oct 12, 2025 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

github-actions bot commented Oct 12, 2025 •
edited
Loading

Channel deleted.

@github-actions
Copy link

github-actions bot commented Oct 12, 2025 •
edited
Loading

Test Results

   71 files    459 suites   0s ⏱️
2 384 tests 2 384 ✅ 0 💤 0 ❌
4 052 runs  4 052 ✅ 0 💤 0 ❌

Results for commit 9155130.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 12, 2025 •
edited
Loading

File Coverage
All files 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/TRADFRI_remote_control.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ikea/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/supported_values.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/shinasystems/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/SLED/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/iris/init.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/pushButton/init.lua 76% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/somfy/somfy_situo_4.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/ecosmart/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/heiman/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/zunzunbee/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/adurosmart/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/robb/init.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/button_utils.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/frient/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/wallhero/init.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-button/src/zigbee-multi-button/vimar/init.lua 96% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 9155130

Kwang-Hui
Kwang-Hui reviewed Oct 13, 2025
View reviewed changes
drivers/SmartThings/zigbee-button/profiles/aqara-double-buttons.yml Outdated
- id: refresh
version: 1
categories:
- name: Button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seojune79 Could you change this to RemoteController also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kwang-Hui Yes, I've reflected that.

@seojune79
change the categories of the main component from 'Button' to 'RemoteC…
e7dc7d5 
…ontroller' in the 'aqara-double-buttons' profile
greens
greens reviewed Oct 23, 2025
View reviewed changes
greens
greens reviewed Oct 23, 2025
View reviewed changes
@greens greens changed the title [Aqara] Wireless Remote Switch T1(Single/Double) WWSTCERT-8426 [Aqara] Wireless Remote Switch T1(Single/Double) Oct 23, 2025
@greens greens changed the title WWSTCERT-8426 [Aqara] Wireless Remote Switch T1(Single/Double) WWSTCERT-8423/8426 [Aqara] Wireless Remote Switch T1(Single/Double) Oct 23, 2025
@seojune79
Added the firmwareUpdate capability to aqara-single-button.yml and re…
d1841bf 
…named the file to one-button-batteryLevel.yml.
greens
greens reviewed Oct 24, 2025
View reviewed changes
drivers/SmartThings/zigbee-button/src/test/test_aqara_button.lua
[1] = {
id = 1,
manufacturer = "LUMI",
model = "lumi.remote.acn003",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This device should still be using the one-button-battery profile, as you have not updated the fingerprint.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the fingerprints for all Aqara Button Devices by implementing the batteryLevel capability.

@greens greens changed the title WWSTCERT-8423/8426 [Aqara] Wireless Remote Switch T1(Single/Double) WWSTCERT-8423/8468[Aqara] Wireless Remote Switch T1(Single/Double) Oct 30, 2025
@greens greens changed the title WWSTCERT-8423/8468[Aqara] Wireless Remote Switch T1(Single/Double) WWSTCERT-8423/8468 [Aqara] Wireless Remote Switch T1(Single/Double) Oct 30, 2025
@greens greens changed the title WWSTCERT-8423/8468 [Aqara] Wireless Remote Switch T1(Single/Double) WWSTCERT-8471/8468 [Aqara] Wireless Remote Switch T1(Single/Double) Oct 30, 2025
@greens greens merged commit b53f7bb into SmartThingsCommunity:main Oct 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greens greens greens approved these changes

@wkhenon wkhenon Awaiting requested review from wkhenon

@pegor-karoglanian pegor-karoglanian Awaiting requested review from pegor-karoglanian

+1 more reviewer

@Kwang-Hui Kwang-Hui Kwang-Hui left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seojune79 @greens @Kwang-Hui